Steel hall development #37

jarabroz · 2021-09-24T11:32:45Z

No description provided.

…Software/RFEM_Python_Client into ExamplesAndDocumentation

bjoernsteinhagen · 2021-09-28T12:24:12Z

Examples/Hall/hall.py

+ i = 1
+ while i <= n-1:
+   j = (i-1) * 5
+   Member(int(4*n+i), MemberType.TYPE_BEAM, j+2, j+7, 0.0, 2, 2)


If we change the "n" input to integer, then the data type conversion here becomes redundant and we can remove it. Same comment applies to line 97

bjoernsteinhagen · 2021-09-28T12:25:47Z

Examples/Hall/hall.py

+#vertical bracing 
+ # add a question about repeating in every block, one yes one no, only beginning and end
+
+ BracingV = input('Would you like to include vertical bracing?\n')


Possibly add: 'Would you like to include vertical bracing? (Y/N)' so that the user knows what to input. German user may say, 'ja' for example which won't work

bjoernsteinhagen · 2021-09-28T12:26:08Z

Examples/Hall/hall.py

+ # add a question about repeating in every block, one yes one no, only beginning and end
+
+ BracingV = input('Would you like to include vertical bracing?\n')
+ if BracingV.lower() == 'yes' or BracingV.lower() == 'y':


Clever use of .lower()! :)

bjoernsteinhagen · 2021-09-28T12:26:51Z

Examples/Hall/hall.py

+
+ BracingV = input('Would you like to include vertical bracing?\n')
+ if BracingV.lower() == 'yes' or BracingV.lower() == 'y':
+  BracingV_C1 = input('Would you like to repeat a vertical bracing in every block?\n')


Same comment as line 103 Include: "(Y/N)" at input end

bjoernsteinhagen · 2021-09-28T12:26:56Z

Examples/Hall/hall.py

+ BracingV = input('Would you like to include vertical bracing?\n')
+ if BracingV.lower() == 'yes' or BracingV.lower() == 'y':
+  BracingV_C1 = input('Would you like to repeat a vertical bracing in every block?\n')
+  if BracingV_C1.lower() == 'yes' or BracingV_C1.lower() == 'y':


Same comment as line 103 Include: "(Y/N)" at input end

bjoernsteinhagen · 2021-09-28T12:27:27Z

Examples/Hall/hall.py

+   Section (3, 'IPE 80',3)
+   i = 1
+   while i <= n-1:
+    k = int(n*4+(n-1)*2)


If we change the "n" input to integer, then the data type conversion here becomes redundant and we can remove it

bjoernsteinhagen · 2021-09-28T12:27:34Z

Examples/Hall/hall.py

+   i = 1
+   while i <= n-1:
+    k = int(n*4+(n-1)*2)
+    if i == 1 or i == int(n-1):


If we change the "n" input to integer, then the data type conversion here becomes redundant and we can remove it

bjoernsteinhagen · 2021-09-28T12:28:04Z

Examples/Hall/hall.py

+     Member(k+4+4*(i-1), MemberType.TYPE_TENSION, (i-1)*5+4, (i-1)*5+10, 0.0, 3, 3)
+     print(k+1+4*(i-1), k+2+4*(i-1), k+3+4*(i-1), k+4+4*(i-1))
+    i += 1  
+  BracingV_C3 = input('Would you like to repeat a vertical bracing in even/odd blocks?\n') # MAKE IT MORE GENERAL! 


Include "(Y/N)" guidance for user

bjoernsteinhagen · 2021-09-28T12:28:15Z

Examples/Hall/hall.py

+   Material (3, 'EN AW-3004 H14')
+   Section (3, 'IPE 80',3)
+   i = 1
+   j = int(4*n + 3*(n-1))


If we change the "n" input to integer, then the data type conversion here becomes redundant and we can remove it

bjoernsteinhagen · 2021-09-28T12:28:48Z

Examples/Hall/hall.py

+   j = int(4*n + 3*(n-1))
+   while i <= n-1:
+    if i% 2 != 0:
+     k = int(n*4+(n-1)*2)


If we change the "n" input to integer, then the data type conversion here becomes redundant and we can remove it

bjoernsteinhagen · 2021-09-28T12:29:02Z

Examples/Hall/hall.py

+ #horizontal bracing
+ # add a question about repeating in every block, one yes one no, only beginning and end
+
+ member_count = int(n*4+(n-1)*2)


If we change the "n" input to integer, then the data type conversion here becomes redundant and we can remove it

bjoernsteinhagen · 2021-09-28T12:29:06Z

Examples/Hall/hall.py

+ member_count = int(n*4+(n-1)*2)
+ BracingH = input('Would you like to include horizontal bracing?\n')
+ if BracingV.lower() == 'yes' or BracingV.lower() == 'y':
+  member_count += (int(n)-1)*4


If we change the "n" input to integer, then the data type conversion here becomes redundant and we can remove it

bjoernsteinhagen · 2021-09-28T12:29:28Z

Examples/Hall/hall.py

+   i = 1
+   while i <= n-1:
+    j = (i-1) * 5
+    Member(int(member_count+1+4*(i-1)), MemberType.TYPE_BEAM, j+2, j+8, 0.0, 3, 3)


If we change the "n" input to integer, then the data type conversion here becomes redundant and we can remove it. Applies to all proceeding lines of code

bjoernsteinhagen · 2021-09-28T12:29:52Z

Examples/Hall/hall.py

+    Member(k+4+4*(i-1), MemberType.TYPE_TENSION, (i-1)*5+4, (i-1)*5+10, 0.0, 3, 3)
+    print(k+1+4*(i-1), k+2+4*(i-1), k+3+4*(i-1), k+4+4*(i-1))
+    i += 1
+  BracingV_C2 = input('Would you like to repeat a vertical bracing only in the first and last block?\n')


Include "(Y/N)" guidance for user

bjoernsteinhagen · 2021-09-28T12:30:06Z

Examples/Hall/hall.py

+ # add a question about repeating in every block, one yes one no, only beginning and end
+
+ member_count = int(n*4+(n-1)*2)
+ BracingH = input('Would you like to include horizontal bracing?\n')


Include "(Y/N)" guidance for user

bjoernsteinhagen · 2021-09-28T12:30:58Z

Examples/Hall/hall.py

+    print(int(member_count+1+4*(i-1)),int(member_count+2+4*(i-1)),int(member_count+3+4*(i-1)),int(member_count+4+4*(i-1)))
+    i += 1
+
+ print("Preparing...")


Nothing is being executed to RFEM between the two print statements, is the "preparing" necessary?

I was thinking as a sign to the user that the script is being processed..what do you think?

bjoernsteinhagen · 2021-09-28T12:31:26Z

Examples/Hall/hall.py

+
+ print("Preparing...")
+ print('Ready!')
+ clientModel.service.finish_modification()


Should we run an analysis? Even if it's just self-weight

not sure, let's discuss it

bjoernsteinhagen · 2021-09-28T12:31:41Z

Examples/Hall/hall.py

+   i = 1
+   j = int(4*n + 3*(n-1))
+   while i <= n-1:
+    if i% 2 != 0:


dogukankaratas · 2021-09-29T11:53:12Z

Examples/Hall/hall.py

+
+if __name__ == '__main__':
+
+ l = float(input('Length of the clear span in m: '))


Bad indentation. If loop indentation should rearrange.

pull-request-quantifier-deprecated · 2021-10-19T13:07:31Z

This PR has 363 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +362 -1
Percentile : 76.3%

Total files changed: 6

Change summary by file extension:
.py : +362 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detetcted.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

CarineKhalil22 and others added 30 commits July 28, 2021 11:35

Create bracing.py

59ef939

Update bracing.py

8a2fec4

Update bracing.py

b30da88

Update bracing.py

7e288dc

Update enums.py

7b9ca91

Update bracing.py

8bc7cbb

Create TypesForBracings

85bded2

Delete TypesForBracings

f3cfb79

Create singleBracing

a69ba09

Delete singleBracing

4cfe438

Create singleBracing.py

e59c4f0

Create kBracing

77bb439

Create vBracing

5c059aa

Update hall.py

461c894

Update hall.py

51584a6

Update hall.py

085cc9c

Delete vBracing

7efb6c6

Delete kBracing

a567662

Create frame.py

fe8dfd5

Update frame.py

dd510d0

Merge branch 'main' into ExamplesAndDocumentation

e181fdc

Update frame.py

b4c562f

Update frame.py

bb6d426

Update hall.py

e1d551f

Update hall.py

9c854ae

Update frame.py

fac1b80

Merge branch 'main' into ExamplesAndDocumentation

4d7fb77

Merge branch 'ExamplesAndDocumentation' of https://github.com/Dlubal-…

d2e25b7

…Software/RFEM_Python_Client into ExamplesAndDocumentation

Update enums.py

52d87de

Update hall.py

ed67680

bjoernsteinhagen reviewed Sep 28, 2021

View reviewed changes

dogukankaratas reviewed Sep 29, 2021

View reviewed changes

CarineKhalil22 added 3 commits October 1, 2021 13:18

Update hall.py

f4565bf

Update hall.py

40b41e1

Update hall.py

293be4d

jarabroz linked an issue Oct 8, 2021 that may be closed by this pull request

Simple parametric example #8

Closed

jarabroz and others added 2 commits October 8, 2021 09:51

Merge branch 'main' into ExamplesAndDocumentation

3f74fb3

Merge branch 'main' into ExamplesAndDocumentation

13b199b

pull-request-quantifier-deprecated bot added Large and removed Extra Large labels Oct 19, 2021

jarabroz merged commit 464d2c9 into main Oct 19, 2021

jarabroz deleted the ExamplesAndDocumentation branch October 19, 2021 13:16


		if __name__ == '__main__':

		l = float(input('Length of the clear span in m: '))

Steel hall development #37

Steel hall development #37

Uh oh!

Conversation

jarabroz commented Sep 24, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bjoernsteinhagen Sep 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pull-request-quantifier-deprecated bot commented Oct 19, 2021

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

bjoernsteinhagen Sep 28, 2021 •

edited

Loading