Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Retrieval in fashion application #44

Closed
shreyashankar opened this issue Mar 21, 2023 · 2 comments
Closed

Refactor Retrieval in fashion application #44

shreyashankar opened this issue Mar 21, 2023 · 2 comments
Labels
M Medium difficulty to complete (could take 2-3 days)

Comments

@shreyashankar
Copy link
Collaborator

No description provided.

@shreyashankar shreyashankar added S Small (1 day) M Medium difficulty to complete (could take 2-3 days) and removed S Small (1 day) labels Mar 21, 2023
@shreyashankar
Copy link
Collaborator Author

Create routing object to replace shouldFit and shouldInfer, so code is less messy. The TODOs:

  • Have routing object in the constructor
  • Execute the trigger lifecycle with respect to its routes, throwing an error if a trigger key isn't in the routes

@shreyashankar
Copy link
Collaborator Author

Done: 9e30296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
M Medium difficulty to complete (could take 2-3 days)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shreyashankar