Skip to content

feat: render hook #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 80 commits into from
Jun 24, 2024
Merged

feat: render hook #21

merged 80 commits into from
Jun 24, 2024

Conversation

@dmackdev
Copy link
Owner

@dmackdev dmackdev commented Jun 15, 2024 •
edited
Loading

Closes #20.

  • BREAKING: Remove response_callback in favour of new on_render/on_render_if hook for more fine-grained
  • Introduce generics to the JsonTree over the JSON value type, to be able to expose the actual JSON value involved in rendering.
  • Add JsonPointerSegment enum for array indices/object keys.
  • Add JsonPointer wrapping JsonPointerSegment slice for JSON pointer utility.
  • Move all rendering to new JsonTreeRenderer.
  • Update "copy to clipboard" demo to use on_render hook.
  • Add demo to showcase editing a JSON document.

dmackdev added 30 commits June 7, 2024 17:55
@dmackdev
Use generics to be able to expose the actual JSON type the tree rende…
c71490a 
…red, for render hooks
@dmackdev
Add RenderHooks abstraction
4058022
@dmackdev
Store RenderHooks within JsonTreeConfig
4c1de44
@dmackdev
Move all rendering to RenderHooks
295afdd
@dmackdev
Use &str instead of &String for response callback
64b8182
@dmackdev
Call response_callback when rendering value
d2c7daf
@dmackdev
Call response_callback when rendering key
7316a3f
@dmackdev
Implicitly call response callback when rendering collapsed delimiters
cde8667
@dmackdev
Remove unused background colour param from render punc
1270761
@dmackdev
Store style within RenderHooks
2f9c7bb
@dmackdev
Revert response callback param type to maintain backwards compatibility
bbcf3f7
@dmackdev
start to on_render_value hook
4138f7c
@dmackdev
change on render value hook to return optional response, in case you …
41cefb6 
…don't care about propagating the response to the response callback
@dmackdev
pass &dyn Display to only convert to string if needed for rendering v…
80533db 
…alue
@dmackdev
add on_render_value_if hook to only register hook based on the condition
ef4da35
@dmackdev
add NestedProperty to capture either object key strings or array nume…
27cb405 
…rical indices
@dmackdev
add missing explicit lifetimes
d249425
@dmackdev
move pointer string to RenderHooks
c3002f5
@dmackdev
move search term to render hooks
4b0b781
@dmackdev
add lifetimes for references used throughout the recursion
b4bd79f
@dmackdev
get rid of extra &str argument in render value callback. add path_seg…
4a75e4d 
…ments to RenderValueContext wip
@dmackdev
add JsonPointer newtype
31c3604 
add lifetimes for borrowing values used in recursion
use NestedProperty for path segments and rendering keys
add post render hook
@dmackdev
add on_post_render_value method
c01aa36
@dmackdev
axe parent, use NestedProperty
b29d71b
@dmackdev
move pointer segment string conversion to NestedProperty to avoid ext…
b06de09 
…ra string alloc
@dmackdev
use RenderKeyContext
6577837
@dmackdev
use RenderPuncContext
9878463
@dmackdev
add render key hook
4dd11f8
@dmackdev
remove uneeded check
eb291fe
@dmackdev
rename arg
e6ddf10
@dmackdev dmackdev mentioned this pull request Jun 17, 2024
Closed
@dmackdev dmackdev marked this pull request as ready for review June 24, 2024 20:34
@dmackdev dmackdev merged commit d9ee6c7 into master Jun 24, 2024
@dmackdev dmackdev deleted the render-hooks branch June 24, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Editing the JSON tree

2 participants

@dmackdev