From a24d768f8b94781a8308991657fd0f1c8656aea4 Mon Sep 17 00:00:00 2001 From: David Madison Date: Mon, 28 Aug 2023 14:33:44 -0400 Subject: [PATCH 1/2] Remove shifter calibration adjust overrides --- src/SimRacing.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SimRacing.cpp b/src/SimRacing.cpp index f3727df..475a553 100644 --- a/src/SimRacing.cpp +++ b/src/SimRacing.cpp @@ -980,7 +980,7 @@ void AnalogShifter::serialCalibration(Stream& iface) { LogitechShifter::LogitechShifter(uint8_t pinX, uint8_t pinY, uint8_t pinRev, uint8_t detectPin) : AnalogShifter(pinX, pinY, pinRev, detectPin) { - this->setCalibration({ 490, 440 }, { 253, 799 }, { 262, 86 }, { 460, 826 }, { 470, 76 }, { 664, 841 }, { 677, 77 }, 0.70, 0.50, 0.70); + this->setCalibration({ 490, 440 }, { 253, 799 }, { 262, 86 }, { 460, 826 }, { 470, 76 }, { 664, 841 }, { 677, 77 }); } //######################################################### From 7ff8c3a372b7d05e2bcb0e4b4353982ef54a06b0 Mon Sep 17 00:00:00 2001 From: David Madison Date: Mon, 28 Aug 2023 14:36:49 -0400 Subject: [PATCH 2/2] Reduced shifter calibration edge offset The high gear X offset calculated by my (G29) shifter was on the edge of being compatible with the G27 shifter - some worked by 1, some didn't work by 1. Setting this to a lower threshold appears to fix compatibility with those shifters without affecting anything else. See issue #10 for further information. --- src/SimRacing.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SimRacing.cpp b/src/SimRacing.cpp index 475a553..fd2da96 100644 --- a/src/SimRacing.cpp +++ b/src/SimRacing.cpp @@ -655,7 +655,7 @@ String Shifter::getGearString() const { */ const float AnalogShifter::CalEngagementPoint = 0.70; const float AnalogShifter::CalReleasePoint = 0.50; -const float AnalogShifter::CalEdgeOffset = 0.70; +const float AnalogShifter::CalEdgeOffset = 0.60; AnalogShifter::AnalogShifter(uint8_t pinX, uint8_t pinY, uint8_t pinRev, uint8_t detectPin) :