Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Behat support #80

Merged
merged 2 commits into from Apr 9, 2019

Conversation

@mnapoli
Copy link
Contributor

commented Apr 5, 2019

See #48

@mnapoli mnapoli referenced this pull request Apr 5, 2019
@dkarlovi

This comment has been minimized.

Copy link

commented Apr 5, 2019

@mnapoli does this mean you've changed your mind about behat? 😀

@mnapoli

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@dkarlovi haha I have to work with Behat for a client. It's OK, but I still think it could be better with PHPUnit (especially since it's an HTTP API with loads of JSON in Gherkin) :)

@dmaicher
Copy link
Owner

left a comment

I think we need to make clear that this will not work if you use a web-server for testing like with selenium and a web-browser like chrome/firefox.

This will only work if the application code is executed within the same php process as the behat tests.

@mnapoli

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@dmaicher good point, just updated the PR!

@dmaicher
Copy link
Owner

left a comment

👍 nice

@dmaicher

This comment has been minimized.

Copy link
Owner

commented Apr 9, 2019

Thanks @mnapoli !

@dmaicher dmaicher merged commit 1e8e3c5 into dmaicher:master Apr 9, 2019

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.