This repository has been archived by the owner. It is now read-only.

No more executable since commit 451662c #16

Closed
bfontaine opened this Issue May 22, 2012 · 4 comments

Comments

Projects
None yet
2 participants
@bfontaine
Contributor

bfontaine commented May 22, 2012

Since commit 451662c, there is no more executable, because the line s.executables = ["glynn"] has been removed. I've fixed the issue in my fork (which I made to add support for a separate file to store username/password).

@dmathieu

This comment has been minimized.

Show comment Hide comment
@dmathieu

dmathieu May 23, 2012

Owner

Damn it, I forgot it.
Could you open a pull request with your commit please ?

Owner

dmathieu commented May 23, 2012

Damn it, I forgot it.
Could you open a pull request with your commit please ?

@bfontaine

This comment has been minimized.

Show comment Hide comment
@bfontaine

bfontaine May 23, 2012

Contributor

Yes, but my commit has been made after another (which added support for a .ftp_auth YAML file in which ftp username/password are defined, which is usefull when your _config.yml file is on Github and you don"t want to show your username/password to everyone), so you would have to accept the pull request, and revert the other commit.

Contributor

bfontaine commented May 23, 2012

Yes, but my commit has been made after another (which added support for a .ftp_auth YAML file in which ftp username/password are defined, which is usefull when your _config.yml file is on Github and you don"t want to show your username/password to everyone), so you would have to accept the pull request, and revert the other commit.

@dmathieu

This comment has been minimized.

Show comment Hide comment
@dmathieu

dmathieu May 23, 2012

Owner

You can create a new branch from the main repository/master, cherry-pick the new commit and push the new branch.
Then the pull request you'll open will have only this new commit, as it's branch doesn't includes your other change.

I like this idea of .ftp_auth file though. If it's tested, you can perhaps do an other pull request for that too :)

Owner

dmathieu commented May 23, 2012

You can create a new branch from the main repository/master, cherry-pick the new commit and push the new branch.
Then the pull request you'll open will have only this new commit, as it's branch doesn't includes your other change.

I like this idea of .ftp_auth file though. If it's tested, you can perhaps do an other pull request for that too :)

@bfontaine

This comment has been minimized.

Show comment Hide comment
@bfontaine

bfontaine May 23, 2012

Contributor

This is the pull request #17.

Contributor

bfontaine commented May 23, 2012

This is the pull request #17.

@bfontaine bfontaine closed this May 23, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.