Passive option #20

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@pzgz
Contributor
pzgz commented Mar 31, 2013

The passive mode is enabled by default right now. But in certain situations, we might not be able to connect to server with passive mode on. So I added an option to disable the passive mode in configuration file.

@dmathieu
Owner
dmathieu commented Apr 1, 2013

Could you write a test about this ?
The travis build fails, but I believe it's not due to your changes. I'll look into it soon.

@pzgz
Contributor
pzgz commented Apr 8, 2013

Thanks, just back from vacation...

About CI build failure, I made a check locally, got following messages:

NOTE: Gem.available? is deprecated, use Specification::find_by_name. It will be removed on or after 2011-11-01.
Gem.available? called from /Users/leon/.rvm/gems/ruby-1.9.2-p320@glynn/gems/sdoc-0.2.20/lib/sdoc/json_backend.rb:9.

It looks like the bundled version for SDoc is pretty out date, maybe bundle update can fix the deprecated issue.

For the tests, I will try to add and send another pull request, thanks for your great plugin.

@dmathieu
Owner

The build is not fixed on master. If you were to rebase your branch on it, and to add tests, I could merge your PR.

@dmathieu
Owner

I have merged your pull request with a few changes in 885bd89
Thanks

@dmathieu dmathieu closed this Apr 24, 2013
@pzgz
Contributor
pzgz commented Apr 25, 2013

@dmathieu Sorry for my absence, full scheduled. Anyway, thanks a lot for your updates, perfect!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment