Allow unbind of metakey combos #137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, *, (), etc. on some international keyboards.
The patch to allow bindings to shiftkey-obscured keys on international keyboards was incomplete.
The Keypress.js bugfix was itself buggy, and prevented some necessary auto-keyup behaviour on mac.
Remove all code related to binding directly to keys hidden behind shift-key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no normalization of key combos when unbinding via string. This means that attempting to unbind a combo like
"meta-a"will always fail. This patch replaces instances of"meta"with the current binding of_metakey, which is platform specific, in the unbind process.