Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Sunrise and Sunset times #22

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@morozgrafix
Copy link
Contributor

commented Nov 23, 2018

Added optional display of the sunrise and sunset times.
boolean showSunriseSunset config parameter toggles display

It looks like this:
image

@lavolp3

This comment has been minimized.

Copy link

commented Nov 28, 2018

Using HH:mm timeformat the implementation looked a bit crowded to me. The time was too close to the symbol.

Would suggest to inlcude this into the css:
.MMM-forecast-io .extras>span { padding-right: 0.3em; }
image

@morozgrafix

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2018

Good call. I will add some CSS styles to it.

@dmcinnes
Copy link
Owner

left a comment

Looks great! I agree with @lavolp3's suggestion, add that and I'll merge.

@morozgrafix

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

padding added to the sunset and sunrise icons, while keeping rest of the info aligned to the right to match rest of the text. Let me know if this works better. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.