Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

pylint fixes

  • Loading branch information...
commit 4eb0674f36f31aecaf8c44ce9eeb746cacaeee9f 1 parent db3c55b
@dmerejkowsky authored
View
3  python/qibuild/archive.py
@@ -61,7 +61,6 @@ def extract_tar(archive_path, dest_dir):
archive = tarfile.open(archive_path)
members = archive.getmembers()
size = len(members)
- res = None
orig_topdir = members[0].name.split(posixpath.sep)[0]
done = 0
# Extract directories with a safe mode.
@@ -191,7 +190,7 @@ def zip_win(directory):
directory = qibuild.sh.to_native_path(directory)
archive_name = qibuild.sh.to_native_path(archive_name)
archive = zipfile.ZipFile(archive_name, "w", zipfile.ZIP_DEFLATED)
- for (root, directories, filenames) in os.walk(directory):
+ for (root, _directories, filenames) in os.walk(directory):
for filename in filenames:
full_path = os.path.join(root, filename)
rel_path = os.path.relpath(full_path, directory)
View
2  python/qibuild/cmake.py
@@ -21,7 +21,7 @@ def get_known_cmake_generators():
"Please install it if necessary and re-run `qibuild config --wizard`")
process = subprocess.Popen([cmake, "--help"],
stdout=subprocess.PIPE)
- (out, err) = process.communicate()
+ (out, _err) = process.communicate()
intersting = False
intersting_lines = list()
magic_line = "The following generators are available on this platform:"
View
6 python/qibuild/cmdparse.py
@@ -107,9 +107,9 @@ def run_action(module_name, args=None, forward_args=None):
# - print usage to the console
# - call SystemExit
# Instead, raise a nice Exception
- def exit():
+ def custom_exit():
return
- parser.exit = exit
+ parser.exit = custom_exit
def error(message):
mess = "Invalid arguments when calling run_action(%s)\n" % module_name
@@ -238,7 +238,7 @@ def fake_error(b):
_cmdparse_no_action = False
try:
- (ns, remaining) = parser_fake.parse_known_args(args)
+ parser_fake.parse_known_args(args)
except:
if _cmdparse_no_action == True:
return False
View
2  python/qibuild/configstore.py
@@ -167,7 +167,7 @@ def __str__(self, pad=True):
max_len = len(k)
for k, v in configdict.iteritems():
if pad:
- pad_space = "".join([ " " for x in range(max_len - len(k)) ])
+ pad_space = " " * (max_len - len(k))
else:
pad_space = ""
output += " %s%s = %s\n" % (k, pad_space, str(v))
View
1  python/qibuild/dylibs.py
@@ -37,7 +37,6 @@ def find_missing_libs_and_frameworks(executable):
# Line looks like:
# /pat/to/foo/dylib (compatibility version ...)
libs_to_check.append(line.split("(")[0].strip())
- res = list()
for lib in libs_to_check:
# Absolute path (/usr/lib/libstdc++.lib, /usr/local/mydep.dylib)
if os.path.isabs(lib):
View
2  python/qibuild/parsers.py
@@ -5,8 +5,6 @@
""" Collection of parser fonctions for various actions
"""
-import qibuild
-
def log_parser(parser):
""" Given a parser, add the options controlling log
"""
View
1  python/qibuild/test/test_config_wizard.py
@@ -12,7 +12,6 @@
import unittest
import mock
-import qibuild
import qibuild.wizard
class FakeInteract:
View
1  python/qibuild/toc.py
@@ -472,7 +472,6 @@ def fix_shared_libs(self, project):
environment variable
"""
- build_dir = project.build_directory
sdk_dir = project.sdk_directory
paths = list()
View
2  python/qidoc/command.py
@@ -8,8 +8,6 @@
"""
-import sys
-import os
import subprocess
def call(cmd, cwd=None, env=None, quiet=False):
Please sign in to comment.
Something went wrong with that request. Please try again.