unlock of unowned mutex?

[Goncalerta]

When running version 1.2.0, when creating the window I'm getting
d:\agent_work\3\s\src\vctools\crt\crtw32\stdcpp\thr\mutex.c(175): unlock of unowned mutex

I thought this problem could have been caused by

GraphViewerCpp/src/graphviewer.cpp

Line 70 in efd90a9

windowInitialization.lock();

But it still persists after removing that line. I'm not sure what is wrong

[dmfrodrigues]

Found the problem. It is related to the fact the mutex is locked by the main thread and unlocked by the event-handling thread. According to the docs of unlock(), this is undefined behavior.

In practice it does not make much sense to unlock from a thread other than the one that locked, but the solution seemed to work at some point. Linux handles it fine (its undefined behavior is just to ignore the fact it is being unlocked from a thread other than the one that locked it), but MSVC doesn't agree with that (and rightfully so).

Most likely will implement that decently as a condition variable+mutex.

[dmfrodrigues]

@Goncalerta please check if the bug is fixed in commit e0beb02 (current head of branch dev).

[Goncalerta]

It seems to be working properly now, thanks!