Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard is always set to lower case #284

Closed
fbruetting opened this issue Oct 9, 2016 · 14 comments
Closed

Keyboard is always set to lower case #284

fbruetting opened this issue Oct 9, 2016 · 14 comments
Assignees
Labels

Comments

@fbruetting
Copy link

Somehow the keyboard is preset to use lower case every time for the first word. I've never seen this in Android before, please correct this behaviour! :)

@dmfs
Copy link
Owner

dmfs commented Oct 9, 2016

Does that affect all fields? I guess that's caused by the input type of the EditText elements.

@fbruetting
Copy link
Author

Yes, this occurs on every text input field.

@lemonboston
Copy link
Contributor

I am not sure I understand the issue, because lower case is the default behavior for EditText's. We don't apply any special capitalizing as I see it.
Should we change that? If yes, to which one, capitalize each word or only start of sentence? (InputType) To all EditTexts in the app, or should we list them here first to select which one needs which kind of capitalization?
Thanks.

@fbruetting
Copy link
Author

Capitalizing the start of each input field text would be nice! Think this fits everywhere.

Gabor Keszthelyi notifications@github.com schrieb am 10.10.2016 18:15:

I am not sure I understand the issue, because lower case is the default behavior for EditText's. We don't apply any special capitalizing as I see it.
Should we change that? If yes, to which one, capitalize each word or only start of sentence? (InputType) To all EditTexts in the app, or should we list them here first to select which one needs which kind of capitalization?
Thanks.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@lemonboston
Copy link
Contributor

@dmfs Can you please confirm that we should set all input text fields in the app, listed below, to capitalize first letters, i.e. set InputType to TYPE_TEXT_FLAG_CAP_SENTENCES:

Create/rename list dialog
Quick add task dialog
Edit/create task screen:
-Title
-Location
-Descritption
-Checklist items
(-URL - no change)

@dmfs
Copy link
Owner

dmfs commented Oct 12, 2016

Yes, I think that totally makes sense in most languages. There may be languages in which it's not common to do that though. So we should keep this in mind. For now we change this for all languages.

@lemonboston
Copy link
Contributor

Ok, I created the pull request.

While we are at it, there are other texts (not input fields) in the app which seemed strange for me first when I saw them in the app that they are lowercase. Like the status, priorities, privacy:
needs action, in process, done, cancelled, incomplete
none, low, medium, high, urgent
not specified, public, private, confidential

Should we maybe capitalize them as well? I think that some people (I think mostly technical people) like to use and see lowercase everywhere, but I would assume that's not the majority. But I am not sure of course, and I am not even a real user, so this is really just a question.

@fbruetting
Copy link
Author

I'm a technical person (:p), but this just applies to source code, where (depending on the language and project) variables are started lowercase. This doesn't apply to the regular language, since grammar in all languages known to me, requires every sentence and headings to be started upper case. So I'd make them upper case, too.

@dmfs
Copy link
Owner

dmfs commented Oct 13, 2016

well, but these words are not used in the context of a sentence or a headline.
Anyway, according to https://material.google.com/style/writing.html#writing-tone these should indeed be capitalized. Please raise a separate issue.

@fbruetting
Copy link
Author

What for?

@dmfs
Copy link
Owner

dmfs commented Oct 13, 2016

Because changing all labels to uppercase is completely a different issue. This one is already fixed by the pull request and will be closed when the PR is merged.
Also it's lower priority, because it doesn't really affect usability, but "merely" the appearance.
Since @lemonboston raised the issue he should file a separate ticket.

@fbruetting
Copy link
Author

I'd say this is included, as you can reference multiple commits with this bug, but ok.

@lemonboston
Copy link
Contributor

Separate issue raised for capitalizing those text: #290.

@fbruetting
Copy link
Author

With half a year passed by and commits done to the source, I wonder why this wasn't included in an update…?

@dmfs dmfs closed this as completed Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants