Skip to content

Conversation

@AndyMacDroo
Copy link
Collaborator

Remove public identifiers from interfaces as they are redundant. Use List interface rather than ArrayList implementation in method signatures

…List<T> interface rather than ArrayList<T> implementation in method signatures
@AndyMacDroo AndyMacDroo requested a review from dmi3coder October 5, 2019 12:04
@AndyMacDroo
Copy link
Collaborator Author

Hey @dmi3coder. Just did a few code quality improvements. Hopefully they don't cause any issues with their incorporation elsewhere. Let me know if any changes are needed 🙂

@coveralls
Copy link

Pull Request Test Coverage Report for Build 98

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.343%

Totals Coverage Status
Change from base Build 96: 0.0%
Covered Lines: 306
Relevant Lines: 335

💛 - Coveralls

@dmi3coder
Copy link
Owner

Good evening @AndyMacDroo! Thank you for PR, I wanted to refactor it a long time ago haha. Works fine, works also correctly on the mobile device, so I'll merge it and create a new release. It'll be better to stick to interfaces earlier :)
Also, I've made you as a contributor so I think you can push branches directly to this project, just use feature/${some_name} for new branches if you'll want to do something later. I can add some code to same branch this way :) But do it as you like, not an issue at all
Great job!

@dmi3coder dmi3coder merged commit 6b8fd2f into dmi3coder:master Oct 5, 2019
@AndyMacDroo
Copy link
Collaborator Author

Thanks Dmitriy 👍

I'll start feature branching from now on 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants