Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain record in task #34

Open
hacksch opened this issue May 12, 2014 · 2 comments
Open

domain record in task #34

hacksch opened this issue May 12, 2014 · 2 comments

Comments

@hacksch
Copy link

@hacksch hacksch commented May 12, 2014

Hello Dmitry,

for your deployment pipeline we are using different enviroments (for content and testing). It's hard to change the domain during the deployment process in the serialized task object.
Therefore we would prefer to choose the domain by database record.

Here is a approach to implement it:
https://drive.google.com/file/d/0B5y_94Qb9kw6d2hUSU5wOXcwak0/edit?usp=sharing

@dmitryd
Copy link
Owner

@dmitryd dmitryd commented May 16, 2014

The patch contains unescaped HTML (possible XSS) and unescaped submitted data is passed to the database (possible SQL injection).

Please, attach patches to issues directly.

Thanks!

@dmitryd
Copy link
Owner

@dmitryd dmitryd commented Jan 5, 2018

In general, this would be a nice feature. However it will break existing configs, so it is not easy to make. Probably, it would need an upgrade wizard. I'll think how to make this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.