Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`no_search` is a suboptimally chosen field to exclude pages from sitemap #91

Open
DenisMir opened this issue Jan 25, 2018 · 3 comments

Comments

@DenisMir
Copy link

commented Jan 25, 2018

It is a big problem that dd_googlesitemap uses the no_search field for its decision on excluding pages from the sitemap.
no_search should be used for excluding pages from the page search (like the index search or solr search etc.).
At the moment it is not possible to exclude pages from the internal search and include it in the sitemap and vice versa.
It would be awesome if dd_googlesitemap could use a configurable field or at least a different field from no_search.

@dmitryd

This comment has been minimized.

Copy link
Owner

commented Jan 30, 2018

If you exclude it from page search, to me it means you want to exclude it from search in general, which means it should not be in the sitemap because sitemap show a list of searchable pages.

@hhchrizzo

This comment has been minimized.

Copy link

commented Feb 19, 2018

I have problems with this too.
In my installation there are some pages for detail view, e.g. tx_news detailpage. The page is set to 'nav_hide=1' and 'no_search=0'. Im using indexed_search and need to index my singlenews.

The problem now is that the singlepage itself is listed in the xml sitemap. If the crawler touches the page without any given news id it will end up in 404 or an exeption.

My current workaround is to exclude pages with type nav_hide=1 in protected function shouldIncludePageInSitemap

@djangones

This comment has been minimized.

Copy link

commented Sep 26, 2018

Basically I agree with Dmitry, but I came across the same problem Chris mentioned, which should be quite a standard situation in Typo3.
So it would definitely be nice to have an additional checkbox to explicitly exclude a page from the sitemap in addition to no_search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.