Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap pin configuration #7

Closed
wants to merge 2 commits into from
Closed

Add bootstrap pin configuration #7

wants to merge 2 commits into from

Conversation

sn00pster
Copy link

Adds configuration options for the boot pin, 2 new defines:

DFU_BOOTSTRAP_PULL:

Can be set to _UP, _DOWN or _NONE to set the desired capability

DFU_BOOTSTRAP_LEVEL:

Can be set to _HIGH or _LOW, allows the logic level to be set according to hardware

(Some of the startup assembler files were including "../config.h" rather than "config.h", I have changed these to "config.h" as it allows sboot_stm32 to be used as a submodule without having to make file changes in tree, you just copy config.h to your own include directory and it uses that version)

@sn00pster sn00pster mentioned this pull request Aug 9, 2019
@dmitrystu
Copy link
Owner

Thank you for your contribution.

I have made a bit different way:

#define DFU_BOOTSTRAP_LEVEL _HIGH/_LOW
#define DFU_BOOTSTRAP_PULL _ENABLE/_DISABLE //in opposite of level if enabled

Tested yesterday with F103 and L433.
Perhaps you forgot to add changes on jumps between bootloader and application.

@sn00pster
Copy link
Author

Perhaps you forgot to add changes on jumps between bootloader and application.

Sorry, I don't understand what you're saying here. Have I missed something out?

I've tested it on L475RC and its working fine, as far as I know I implemented the rest of the changes as necessary for the other micros?

@sn00pster
Copy link
Author

Oh hang on, I see what you mean. I must have removed part of the ifdef when I was cleaning up, let me fix that.

Sorry!

@sn00pster
Copy link
Author

@dmitrystu I've updated the code with the changes, sorry about that, in my haste I just missed out the actual final bit of logic.

@dmitrystu dmitrystu closed this Aug 10, 2019
@sn00pster sn00pster deleted the bootpin branch August 12, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants