Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Early stop GAT #750

Merged
merged 6 commits into from Aug 21, 2019

Conversation

@VoVAllen
Copy link
Collaborator

VoVAllen commented Aug 9, 2019

Description

Get 71.5% accuracy on citeseer (comparing to 70.7% without early stopping)
#743

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR

Changes

Copy link
Member

yzh119 left a comment

Please change the MXNet version accordingly.

VoVAllen added 3 commits Aug 12, 2019
@VoVAllen

This comment has been minimized.

Copy link
Collaborator Author

VoVAllen commented Aug 13, 2019

MXNet version added

Copy link
Member

jermainewang left a comment

LGTM. One suggestion. Consider move the early stopping utility to examples/pytorch and examples/mxnet so other examples could reuse it.

@VoVAllen

This comment has been minimized.

Copy link
Collaborator Author

VoVAllen commented Aug 21, 2019

I just realized it's not good to import from parent directory, which may results in problem for fresh user to use. I'm thinking of moving them to the model zoo utils in the future. I'd like to keep the current file structure for now.

@VoVAllen VoVAllen merged commit 0f12763 into dmlc:master Aug 21, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.