Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sampler] Metapath sampler for metapath2vec #861

Merged
merged 11 commits into from Sep 26, 2019

Conversation

BarclayII
Copy link
Collaborator

Description

Provides the (cyclic) metapath-based random walk sampler required by metapath2vec.

This implementation takes 857 seconds to generate a corpus of the same size as that in Metapath2vec (which takes 1563 seconds) on AMiner.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change

@BarclayII BarclayII requested review from aksnzhy and jermainewang and removed request for aksnzhy September 20, 2019 02:03
Copy link
Member

@jermainewang jermainewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. There are some conflicts to be resolved. Suggest using OMP to parallelize the outer loop.

python/dgl/contrib/sampling/randomwalk.py Show resolved Hide resolved
python/dgl/contrib/sampling/randomwalk.py Outdated Show resolved Hide resolved
python/dgl/contrib/sampling/randomwalk.py Show resolved Hide resolved
python/dgl/convert.py Outdated Show resolved Hide resolved
src/graph/sampler/metapath.cc Show resolved Hide resolved
@jermainewang jermainewang merged commit e3921d5 into dmlc:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants