Minor make adjustments, fix warnings #199
Conversation
| LOG(FATAL) << "Need to set enviroment variable AWS_ACCESS_KEY_ID to use S3"; | ||
| } | ||
| if (seckey == NULL) { | ||
| if (seckey == NULL || !*seckey) { |
There was a problem hiding this comment.
My implementation returns NULL (Ubuntu). However, the documentation is not specific on this and states that it returns NULL if the environment variable is not found. However, I can put an empty variable in the environment:
[coolivie@DEV:]export FOO=]env | grep FOO
[coolivie@DEV:
FOO=
[coolivie@DEV:~]
There was a problem hiding this comment.
By googling that, I see cases of some implementations returning an empty string.
Also, this example does not appear to check:
http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libc/stdlib/getenv.c?rev=1.19&content-type=text/x-cvsweb-markup
There was a problem hiding this comment.
Note that this Apple Open Source putenv and setenv both will insert and retrieve empty values:
(I compiled and tried this code and does, in fact, return an empty string)
There was a problem hiding this comment.
ok I'll merge this since it looks like it wouldn't hurt.
No description provided.