Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

update gbw model after transform API refactoring #294

Merged
merged 3 commits into from Aug 17, 2018
Merged

update gbw model after transform API refactoring #294

merged 3 commits into from Aug 17, 2018

Conversation

eric-haibin-lin
Copy link
Member

Description

Tested on master branch with test ppl 43.72.

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin mentioned this pull request Aug 17, 2018
Closed
4 tasks
eric-haibin-lin
eric-haibin-lin commented Aug 17, 2018
View reviewed changes
gluonnlp/data/corpora/google_billion_word.py
self._archive_vocab = ('gbw-b3e83215.zip',
'9502eb728bf492a382b1cd57b374734ff82f8553')
self._archive_vocab = ('gbw-ebb1a287.zip',
'63b335dcc27b6804d0a14acb88332d2602fe0f59')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hash from @szha's second upload of gbw-ebb1a287.zip

@mli
Copy link
Member

mli commented Aug 17, 2018

Job PR-294/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-294/1/index.html

@mli
Copy link
Member

mli commented Aug 17, 2018

Job PR-294/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-294/2/index.html

szha
szha approved these changes Aug 17, 2018
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leezu FYI

@szha szha mentioned this pull request Aug 17, 2018
Closed
20 tasks
@mli
Copy link
Member

mli commented Aug 17, 2018

Job PR-294/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-294/3/index.html

@eric-haibin-lin eric-haibin-lin merged commit 8d568f0 into dmlc:master Aug 17, 2018
@szha szha mentioned this pull request Aug 18, 2018
Closed
@eric-haibin-lin eric-haibin-lin deleted the gbw-retrain branch September 12, 2018 05:21
paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019
@eric-haibin-lin
update gbw model after transform API refactoring (dmlc#294)
0cf7c07 
* update gbw model after transform API refactoring

* update vocab

* update zip hash
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-haibin-lin @mli @szha