Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention download link in the BERT tutorial #440

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
4 participants
@eric-haibin-lin
Copy link
Member

commented Nov 28, 2018

Description

As title

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from szha as a code owner Nov 28, 2018

@mli

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

@codecov

This comment has been minimized.

Copy link

commented Nov 28, 2018

Codecov Report

Merging #440 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   72.78%   72.78%           
=======================================
  Files         113      113           
  Lines        9609     9609           
=======================================
  Hits         6994     6994           
  Misses       2615     2615
Flag Coverage Δ
#PR440 72.78% <ø> (?)
#master ?
#notserial 50.21% <ø> (ø) ⬆️
#py2 72.56% <ø> (ø) ⬆️
#py3 72.64% <ø> (ø) ⬆️
#serial 57.48% <ø> (ø) ⬆️
the complete fine-tuning scripts.
transformed data into the model. For demonstration purpose, we skipped the warmup learning rate
schedule and validation on dev dataset used in the original implementation. Please visit
[here](../../model_zoo/bert/index.rst) for the complete fine-tuning scripts.

This comment has been minimized.

Copy link
@cgraywang

cgraywang Nov 28, 2018

Contributor

The link seems not work. Could you double check?

@cgraywang
Copy link
Contributor

left a comment

LGTM

@szha

szha approved these changes Nov 29, 2018

@eric-haibin-lin eric-haibin-lin merged commit 5fb695a into dmlc:master Nov 29, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 461f383...84302eb
Details
codecov/project 72.78% remains the same compared to 461f383
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@eric-haibin-lin eric-haibin-lin deleted the eric-haibin-lin:bert-patch branch Dec 15, 2018

@szha szha referenced this pull request Jan 12, 2019

Closed

BERT Download link broken #552

paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.