Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Revert an unintended change #525

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
4 participants
@eric-haibin-lin
Copy link
Member

commented Jan 4, 2019

Description

I didn't intend to check in this code to GluonNLP. It was added during local testing. Reverting.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from szha as a code owner Jan 4, 2019

@szha

szha approved these changes Jan 4, 2019

@mli

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 5, 2019

Codecov Report

Merging #525 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   70.13%   69.97%   -0.16%     
==========================================
  Files         122      122              
  Lines       10514    10456      -58     
==========================================
- Hits         7374     7317      -57     
+ Misses       3140     3139       -1
Flag Coverage Δ
#PR501 ?
#PR525 69.97% <ø> (?)
#master ?
#notserial 46.66% <ø> (+0.09%) ⬆️
#py2 69.74% <ø> (-0.16%) ⬇️
#py3 69.83% <ø> (-0.16%) ⬇️
#serial 54.52% <ø> (-0.25%) ⬇️
1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jan 5, 2019

Codecov Report

Merging #525 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   70.13%   69.97%   -0.16%     
==========================================
  Files         122      122              
  Lines       10514    10456      -58     
==========================================
- Hits         7374     7317      -57     
+ Misses       3140     3139       -1
Flag Coverage Δ
#PR501 ?
#PR525 69.97% <ø> (?)
#master ?
#notserial 46.66% <ø> (+0.09%) ⬆️
#py2 69.74% <ø> (-0.16%) ⬇️
#py3 69.83% <ø> (-0.16%) ⬇️
#serial 54.52% <ø> (-0.25%) ⬇️

@eric-haibin-lin eric-haibin-lin requested a review from astonzhang Jan 7, 2019

@astonzhang astonzhang merged commit a121733 into dmlc:master Jan 7, 2019

2 of 3 checks passed

codecov/project 69.97% (-0.16%) compared to 5db80c4
Details
codecov/patch Coverage not affected when comparing 5db80c4...935f998
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@eric-haibin-lin eric-haibin-lin deleted the eric-haibin-lin:revert branch May 9, 2019

paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.