This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
[BUGFIX] Update hash of wiki_cn_cased and wiki_multilingual_cased vocab #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job PR-655/1 is complete. |
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
+ Coverage 63.04% 63.73% +0.68%
==========================================
Files 151 141 -10
Lines 13779 12902 -877
==========================================
- Hits 8687 8223 -464
+ Misses 5092 4679 -413
|
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
+ Coverage 63.04% 63.78% +0.73%
==========================================
Files 151 141 -10
Lines 13779 12902 -877
==========================================
- Hits 8687 8229 -458
+ Misses 5092 4673 -419
|
szha
approved these changes
Apr 7, 2019
Ok, I will add unit tests later. |
|
Job PR-655/2 is complete. |
gigasquid
pushed a commit
to gigasquid/gluon-nlp
that referenced
this pull request
May 6, 2019
…ab (dmlc#655) * update hash of wiki_cn_cased and wiki_multilingual_cased * add unit test for bertvocab
paperplanet
pushed a commit
to paperplanet/gluon-nlp
that referenced
this pull request
Jun 9, 2019
…ab (dmlc#655) * update hash of wiki_cn_cased and wiki_multilingual_cased * add unit test for bertvocab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug mentioned in #652 .
wiki_cn_casedvocab andwiki_multilingual_casedvocab have been converted. Now update the hash code of the relevant vocab.Checklist
Essentials
Changes
Comments