Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[DOC] update download button in tutorial and model zoo #746

Merged
merged 3 commits into from Jun 18, 2019

Conversation

szha
Copy link
Member

@szha szha commented Jun 3, 2019

Description

doc website fixes.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)

Changes

  • update download button in tutorial and model zoo. download buttons are now after the first header in the form of a button.
  • allow horizontal scroll when there is content overflow. (e.g. the huge table in language model)
  • make navbar responsive.
  • make header links appear when hovering the title.

Comments

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

❗ No coverage uploaded for pull request head (download_button@83df8ff). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #746 into master will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   90.21%   90.63%   +0.41%     
==========================================
  Files          64       64              
  Lines        6233     6233              
==========================================
+ Hits         5623     5649      +26     
+ Misses        610      584      -26
Impacted Files Coverage Δ
src/gluonnlp/data/stream.py 89.61% <0%> (+0.54%) ⬆️
src/gluonnlp/data/word_embedding_evaluation.py 96.96% <0%> (+0.75%) ⬆️
src/gluonnlp/data/batchify/batchify.py 96.29% <0%> (+1.23%) ⬆️
src/gluonnlp/data/dataset.py 98.41% <0%> (+1.58%) ⬆️
src/gluonnlp/data/transforms.py 80.28% <0%> (+3.01%) ⬆️
src/gluonnlp/data/corpora/wikitext.py 100% <0%> (+5.17%) ⬆️
src/gluonnlp/model/parameter.py 100% <0%> (+8%) ⬆️

@mli
Copy link
Member

mli commented Jun 3, 2019

Job PR-746/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/1/index.html

@szha szha changed the title [DOC] update download button in tutorial and model zoo [WIP][DOC] update download button in tutorial and model zoo Jun 5, 2019
@mli
Copy link
Member

mli commented Jun 5, 2019

Job PR-746/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/2/index.html

@eric-haibin-lin
Copy link
Member

The TOC sidebar looks fine here @szha

@mli
Copy link
Member

mli commented Jun 15, 2019

Job PR-746/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/3/index.html

@mli
Copy link
Member

mli commented Jun 15, 2019

Job PR-746/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/4/index.html

@mli
Copy link
Member

mli commented Jun 15, 2019

Job PR-746/5 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/5/index.html

@mli
Copy link
Member

mli commented Jun 15, 2019

Job PR-746/6 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/6/index.html

@mli
Copy link
Member

mli commented Jun 16, 2019

Job PR-746/8 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/8/index.html

@szha szha mentioned this pull request Jun 16, 2019
@szha szha changed the title [WIP][DOC] update download button in tutorial and model zoo [DOC] update download button in tutorial and model zoo Jun 16, 2019
@mli
Copy link
Member

mli commented Jun 16, 2019

Job PR-746/9 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/9/index.html

@szha szha requested a review from leezu June 16, 2019 23:36
@mli
Copy link
Member

mli commented Jun 17, 2019

Job PR-746/10 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/10/index.html

@mli
Copy link
Member

mli commented Jun 17, 2019

Job PR-746/11 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/11/index.html

@mli
Copy link
Member

mli commented Jun 18, 2019

Job PR-746/13 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-746/13/index.html

@szha szha merged commit c4aef52 into dmlc:master Jun 18, 2019
@szha szha deleted the download_button branch June 18, 2019 05:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants