support PORT env for docker #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marathon use port0 use port
eric-haibin-lin
added a commit
to eric-haibin-lin/ps-lite
that referenced
this pull request
Feb 6, 2021
* Gather scatter pattern test and fixes This commit builds on top of dmlc#46, with an update on tests and scripts. It also makes two minor changes to UCXVan: * ZPull does not require a preceding ZPush * pull request still pass the correct value of val_len in msg.meta * added a thread to ensure the order of push/pull request messages upon reception * It also adds a USE_CUDA=1 compilation option. - fix w_pool_ for pull - fix val len bug - add USE_CUDA=1 compilation option - unset export UCX_TLS=ib,cuda - support 48 bit keys Co-authored-by: Chengyu Dai <chengyu.dai@bytedance.com> Co-authored-by: Yulu Jia <yulu.jia@bytedance.com> Co-authored-by: haibin.lin <haibin.lin@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In marathon, it will generate a random port for every docker container and pass to container through env var $PORT.
I do not know if this change is too hack. If you have better suggestions, I can change it.