Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittests mock, cleanup #111

Merged
merged 4 commits into from Oct 1, 2019

Conversation

@chenqin
Copy link
Contributor

commented Sep 29, 2019

cleanup pr following removal of is_bootstrap parameter in 9a7ac85

boostrap_cache no longer support after first loadcheckpoint called, we can reuse seq_no diff with load_cache to see if a worker in recover mode.

support spark mock failure, not exit process

add unittests on mock interface

@trivialfis @hcho3 @CodingCat

@chenqin chenqin force-pushed the chenqin:master branch from b863d2e to 540dbf2 Sep 30, 2019
@chenqin chenqin changed the title add missing parameters in mock, remove redundant logic unittests mock Sep 30, 2019
@chenqin chenqin changed the title unittests mock unittests mock, cleanup Sep 30, 2019
@CodingCat

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

waiting for CI

@chenqin

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

@hcho3 @trivialfis can we merge this

Copy link
Member

left a comment

Will merge it. See inlined questions, just want to understand the changes a bit more. Sorry for the extra steps.

test/model_recover.cc Show resolved Hide resolved
src/allreduce_robust.h Show resolved Hide resolved
@CodingCat CodingCat merged commit af7281a into dmlc:master Oct 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@CodingCat

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

oh @chenqin, @trivialfis has a few questions here

@chenqin

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

oh @chenqin, @trivialfis has a few questions here

working on a post follow up pr

nateagr added a commit to criteo-forks/rabit that referenced this pull request Oct 9, 2019
* cleanup, fix issue involved after remove is_bootstrap parameter

* misc

* clean

* add unittests
nateagr added a commit to criteo-forks/rabit that referenced this pull request Oct 9, 2019
* cleanup, fix issue involved after remove is_bootstrap parameter

* misc

* clean

* add unittests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.