[Relay] [Op] Squeeze #1858
Merged
[Relay] [Op] Squeeze #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Oct 8, 2018
include/tvm/relay/attrs/transform.h
Outdated
| struct SqueezeAttrs : public tvm::AttrsNode<SqueezeAttrs> { | ||
| Array<IndexExpr> axis; | ||
|
|
||
| TVM_DECLARE_ATTRS(ExpandDimsAttrs, "relay.attrs.ExpandDimsAttrs") { |
|
@joshpoll @siju-samuel @junrushao1994 please review |
|
Will do tmr morning |
siju-samuel
reviewed
Oct 8, 2018
python/tvm/relay/op/transform.py
Outdated
| """ | ||
| axes = axes or [] | ||
| return _make.transpose(data, list(axes)) | ||
|
|
||
|
|
||
| def squeeze(data, axes=None): | ||
| """Remove the axis that equals to 1 in an array |
There was a problem hiding this comment.
Can rephrase to "Squeeze axes in the array."
src/relay/op/tensor/transform.cc
Outdated
| } | ||
|
|
||
| RELAY_REGISTER_OP("squeeze") | ||
| .describe(R"code(squeeze the input tensor at the dimensions given by `axis` |
There was a problem hiding this comment.
Squeeze the input tensor at the dimensions given by axes
MarisaKirisame
force-pushed
the
squeeze
branch
from
89ba54b
to
6c85204
Compare
junrushao
requested changes
Oct 8, 2018
joshpoll
suggested changes
Oct 8, 2018
junrushao
approved these changes
Oct 8, 2018
MarisaKirisame
force-pushed
the
squeeze
branch
2 times, most recently
from
dbc74e6
to
ce44854
Compare
tqchen
requested changes
Oct 13, 2018
MarisaKirisame
force-pushed
the
squeeze
branch
from
ce44854
to
1c27c23
Compare
|
@tqchen can you give it another look? I had addressed all comment. |
tqchen
approved these changes
Oct 15, 2018
tqchen
added
status: accepted
and removed
status: need update
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.