Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELAY]Vision ops for yolo #1941

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
None yet
4 participants
@siju-samuel
Copy link
Member

commented Oct 20, 2018

#1799
The following yolo ops are added in relay

  • Reorg

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.

@siju-samuel siju-samuel force-pushed the siju-samuel:relay_yolo_ops branch from 89d965d to 63fa16a Oct 21, 2018

return _make.yolo_region(data)


def yolov3_yolo(data):

This comment has been minimized.

Copy link
@tqchen

tqchen Oct 21, 2018

Member

This is quite confusing as it is unclear what specifically the operation this, please write out more details about what is the operation about


def yolo_region(data):
"""Yolo region operation used for detection.

This comment has been minimized.

Copy link
@tqchen

tqchen Oct 21, 2018

Member

document the behavior of the operation as it is non-conventional


def yolo_reorg(data, stride=1):
"""Yolo reorg operation. This layer reorganize the output based on the stride value.
Its function is mostly shape transform.

This comment has been minimized.

Copy link
@tqchen

tqchen Oct 21, 2018

Member

document the behavior of the operation

@tqchen

This comment has been minimized.

Copy link
Member

commented Oct 28, 2018

given #1974 maybe we want to consider close this pr

@siju-samuel

This comment has been minimized.

Copy link
Member Author

commented Oct 28, 2018

region and yolo op can be defenitely removed. But we may need to keep yolo_reorg as realizing this from frontend is difficult.

@siju-samuel siju-samuel force-pushed the siju-samuel:relay_yolo_ops branch 3 times, most recently from 68d3e10 to ee7803e Nov 2, 2018

@siju-samuel siju-samuel force-pushed the siju-samuel:relay_yolo_ops branch 2 times, most recently from 68a637f to 4ed21d3 Nov 22, 2018

@yzhliu

This comment has been minimized.

Copy link
Member

commented Dec 18, 2018

What is the status of this PR?

@siju-samuel siju-samuel force-pushed the siju-samuel:relay_yolo_ops branch from 4ed21d3 to f82dea1 Feb 26, 2019

@siju-samuel siju-samuel force-pushed the siju-samuel:relay_yolo_ops branch from f82dea1 to 8a20a5f Feb 26, 2019

@siju-samuel siju-samuel referenced this pull request Feb 26, 2019

Closed

[RELAY][FRONEND] Frontend scalfolding #2246

8 of 8 tasks complete
@tqchen

tqchen approved these changes Feb 27, 2019

@tqchen tqchen merged commit b5f46c4 into dmlc:master Feb 27, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@yzhliu yzhliu referenced this pull request Mar 2, 2019

Open

[DEV] TVM v0.6 Roadmap #2623

8 of 28 tasks complete

wweic added a commit to neo-ai/tvm that referenced this pull request Mar 9, 2019

wweic added a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019

wweic added a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.