Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUST][FRONTEND] Add rust frontend v0.1 #2292

Merged
merged 20 commits into from Feb 3, 2019

Conversation

Projects
None yet
6 participants
@ehsanmok
Copy link
Contributor

commented Dec 14, 2018

Overview

I'm delighted to submit this PR which adds Rust runtime frontend support as part of RFC 1601.

You can see the dev here. Here's a summary

  1. Add tvm_frontend bindings and idiomatic Rust API.
  2. Create a common crate refactoring TVMArgValue and TVMRetValue and unifying FFI across runtime and frontend.
  3. Various cleaning up and adding more documentations.

@nhynes @tqchen @jroesch

resolves #2306

@ehsanmok ehsanmok referenced this pull request Dec 14, 2018

Closed

[RFC] Rust Support #1601

@nhynes nhynes self-requested a review Dec 14, 2018

@ehsanmok ehsanmok force-pushed the ehsanmok:rust_frontend branch 5 times, most recently from 7239200 to f38114a Dec 14, 2018

Show resolved Hide resolved rust/Cargo.toml Outdated
Show resolved Hide resolved rust/frontend/.gitignore
Show resolved Hide resolved rust/frontend/.rustfmt.toml Outdated
Show resolved Hide resolved rust/frontend/.travis.yml Outdated
Show resolved Hide resolved rust/frontend/Cargo.toml Outdated
Show resolved Hide resolved rust/frontend/src/value.rs Outdated
Show resolved Hide resolved rust/frontend/tvm-sys/Cargo.toml Outdated
Show resolved Hide resolved rust/frontend/tvm-sys/src/bindgen.rs Outdated
Show resolved Hide resolved rust/frontend/tvm-sys/build.rs Outdated
Show resolved Hide resolved rust/runtime/.gitignore Outdated
@nhynes
Copy link
Member

left a comment

nice work so far! a few more comments for your perusal :)

I'm looking forward to having this merged!

Show resolved Hide resolved rust/frontend/src/function.rs Outdated
Show resolved Hide resolved rust/frontend/src/function.rs Outdated
Show resolved Hide resolved rust/frontend/src/function.rs Outdated
Show resolved Hide resolved rust/frontend/src/function.rs
Show resolved Hide resolved rust/frontend/src/function.rs Outdated
Show resolved Hide resolved rust/frontend/src/internal_api.rs Outdated
Show resolved Hide resolved rust/frontend/src/module.rs Outdated
Show resolved Hide resolved rust/frontend/src/module.rs Outdated
Show resolved Hide resolved rust/frontend/src/module.rs Outdated
Show resolved Hide resolved rust/frontend/src/function.rs Outdated
Show resolved Hide resolved rust/frontend/src/function.rs Outdated

@ehsanmok ehsanmok force-pushed the ehsanmok:rust_frontend branch from f38114a to 82b0961 Dec 16, 2018

Show resolved Hide resolved rust/frontend/Cargo.toml Outdated
Show resolved Hide resolved rust/frontend/src/function.rs Outdated
Show resolved Hide resolved rust/frontend/src/function.rs Outdated

@ehsanmok ehsanmok force-pushed the ehsanmok:rust_frontend branch from 82b0961 to 3a06735 Dec 17, 2018

@ehsanmok

This comment has been minimized.

Copy link
Contributor Author

commented Dec 17, 2018

@nhynes @tqchen how come CI tvm-sys build is successful (tvm_runtime is found in ld path) as first dependency though tvm_frontend cannot find tvm_runtime?

@nhynes

This comment has been minimized.

Copy link
Member

commented Dec 18, 2018

tvm_frontend cannot find tvm_runtime

In what context is this bug occurring? The most likely cause is that LD_LIBRARY_PATH simply becomes unset.

Show resolved Hide resolved rust/frontend/tvm-sys/LICENSE Outdated
@ehsanmok

This comment has been minimized.

Copy link
Contributor Author

commented Dec 18, 2018

@nhynes Please checkout task_rust.sh.

@nhynes

This comment has been minimized.

Copy link
Member

commented Dec 18, 2018

What happens if you also export LD_LIBRARY_PATH a la https://github.com/dmlc/tvm/blob/master/tests/scripts/task_java_unittest.sh#L3

@ehsanmok

This comment has been minimized.

Copy link
Contributor Author

commented Dec 18, 2018

@nhynes Already exported in tests/scripts/task_rust.sh and I didn't change that.

@ehsanmok ehsanmok force-pushed the ehsanmok:rust_frontend branch from 3a06735 to 70de494 Dec 18, 2018

@jroesch

This comment has been minimized.

Copy link
Member

commented Dec 18, 2018

I will take a pass over this later today.

@ehsanmok ehsanmok force-pushed the ehsanmok:rust_frontend branch 3 times, most recently from 712e305 to be1fe4e Dec 19, 2018

ehsanmok and others added some commits Jan 25, 2019

@nhynes nhynes force-pushed the ehsanmok:rust_frontend branch from 837ebcc to 0d6d04e Feb 3, 2019

@nhynes nhynes force-pushed the ehsanmok:rust_frontend branch from 8488bb2 to 4143aa3 Feb 3, 2019

@nhynes nhynes merged commit e2970b2 into dmlc:master Feb 3, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

libing4752 added a commit to libing4752/tvm that referenced this pull request Feb 18, 2019

merrymercy pushed a commit to merrymercy/tvm that referenced this pull request Feb 18, 2019

wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019

wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019

@yzhliu yzhliu referenced this pull request Mar 2, 2019

Open

[DEV] TVM v0.6 Roadmap #2623

8 of 28 tasks complete

ricann pushed a commit to ricann/tvm that referenced this pull request Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.