[Relay][Transform] quantize opt passes to pass manager #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tqchen Should I keep the quantize related two passes in the quantize namespace and |
jroesch
reviewed
Jun 4, 2019
jroesch
requested review from
tqchen and
ZihengJiang
and removed request for
tqchen
|
Otherwise looks good to me, we should get @ZihengJiang and @tqchen to sign off. |
jroesch
approved these changes
Jun 4, 2019
ZihengJiang
requested changes
Jun 4, 2019
ZihengJiang
reviewed
Jun 4, 2019
|
Let us not put them into the c++ for now, but just uses the pass infra in the python now. |
|
@ZihengJiang PTAL. Thanks. |
zhiics
force-pushed
the
quantize_opt
branch
2 times, most recently
from
7952621
to
0338ed6
Compare
ZihengJiang
approved these changes
Jun 13, 2019
|
LGTM! Could you resolve the conflicts and do the merge? |
|
@ZihengJiang rebased. I don't have the permission to merge. Could you or @jroesch merge it? Thanks. |
|
Thanks, @zhiics @ZihengJiang @jroesch , this PR is now merged |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Jun 26, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3273
This PR moves optimizations in
quantize.pyto the pass manager, i.e. the sequence of passes are moved toSequential.cc @tqchen @vinx13 @ZihengJiang @jroesch @MarisaKirisame