Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPI] Memoize winograd matrix #3687

Merged
merged 3 commits into from Aug 2, 2019

Conversation

@merrymercy
Copy link
Member

commented Aug 1, 2019

I found #3553 makes feature extraction for arm cpu about 4x slower, which will cause tuning about 2x slower.

Memoizing winograd matrix computation can fix this performance regression, and is slightly faster the the original hard-coded one.

@merrymercy

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

@merrymercy

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

@cbalint13 please approve

@cbalint13

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Looks very good to me.

@tqchen

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@merrymercy please act on @cbalint13 's comment

@merrymercy

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

It is resolved.

@tqchen tqchen merged commit 7de8a3a into dmlc:master Aug 2, 2019
5 checks passed
5 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
windows_mac_build Build #20190801.17 succeeded
Details
windows_mac_build (MacOS_XCode9) MacOS_XCode9 succeeded
Details
windows_mac_build (Windows_VS2017_x64) Windows_VS2017_x64 succeeded
Details
windows_mac_build (Windows_VS2017_x86) Windows_VS2017_x86 succeeded
Details
@tqchen

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

@merrymercy merrymercy deleted the merrymercy:pr-memorize-winograd branch Aug 3, 2019
wweic added a commit to wweic/tvm that referenced this pull request Aug 9, 2019
* [TOPI] Memoize winograd matrix

* lint

* Fix name
wweic added a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
* [TOPI] Memoize winograd matrix

* lint

* Fix name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.