Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align naming rule for OpAttributeUnImplemented #3695

Merged

Conversation

@cchung100m
Copy link
Contributor

commented Aug 2, 2019

Hi @tqchen

I saw the class name OpAttributeUnimplemented in python/tvm/error.py that did not follow the naming rule like OpNotImplemented. Therefore I align the class name in this PR, I would appreciate if you can help to review/merge it, thanks. :)

@tqchen
tqchen approved these changes Aug 2, 2019
@tqchen tqchen merged commit f9ba0db into dmlc:master Aug 2, 2019
5 checks passed
5 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
windows_mac_build Build #20190802.12 succeeded
Details
windows_mac_build (MacOS_XCode9) MacOS_XCode9 succeeded
Details
windows_mac_build (Windows_VS2017_x64) Windows_VS2017_x64 succeeded
Details
windows_mac_build (Windows_VS2017_x86) Windows_VS2017_x86 succeeded
Details
@tqchen

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Thanks @cchung100m !

@cchung100m cchung100m deleted the cchung100m:align_naming_rule_OpAttributeUnimplemented branch Aug 3, 2019
wweic added a commit to wweic/tvm that referenced this pull request Aug 9, 2019
wweic added a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.