Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] Fix the potential index overflow #3751

Merged

Conversation

@cchung100m
Copy link
Contributor

commented Aug 11, 2019

Hi @tqchen @YPBlib

Following the issue 3652, I add the additional check to make sure that the cond_shape would only be checked when the index i small than cond_shape and x_shape both in order to avoid a case when cond_shape.size() == 1 but x_shape.size is not.

@cchung100m cchung100m changed the title Fix the potential index overflow [Relay] Fix the potential index overflow Aug 11, 2019
@tqchen
tqchen approved these changes Aug 12, 2019
@tqchen tqchen merged commit 9161efb into dmlc:master Aug 12, 2019
5 checks passed
5 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
windows_mac_build Build #20190811.6 succeeded
Details
windows_mac_build (MacOS_XCode9) MacOS_XCode9 succeeded
Details
windows_mac_build (Windows_VS2017_x64) Windows_VS2017_x64 succeeded
Details
windows_mac_build (Windows_VS2017_x86) Windows_VS2017_x86 succeeded
Details
@tqchen

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Thanks @cchung100m

wweic added a commit to neo-ai/tvm that referenced this pull request Aug 16, 2019
@cchung100m cchung100m deleted the cchung100m:transform.cc_potential_index_overflow branch Aug 20, 2019
anijain2305 added a commit to anijain2305/tvm that referenced this pull request Aug 22, 2019
wweic added a commit to neo-ai/tvm that referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.