Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Keras] axis of softmax #3834

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@yongwww
Copy link
Contributor

commented Aug 26, 2019

@yongwww yongwww force-pushed the yongwww:keras-bugs branch from 338e88e to bcecb93 Aug 26, 2019
@yongwww yongwww force-pushed the yongwww:keras-bugs branch from bcecb93 to d13ec12 Aug 26, 2019
@kevinthesun kevinthesun requested review from kazum and Huyuwei Aug 26, 2019
@kevinthesun kevinthesun merged commit 07a83a6 into dmlc:master Aug 28, 2019
5 checks passed
5 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
windows_mac_build Build #20190826.6 succeeded
Details
windows_mac_build (MacOS_XCode9) MacOS_XCode9 succeeded
Details
windows_mac_build (Windows_VS2017_x64) Windows_VS2017_x64 succeeded
Details
windows_mac_build (Windows_VS2017_x86) Windows_VS2017_x86 succeeded
Details
@kevinthesun

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

Thanks!

@@ -117,7 +117,16 @@ def _convert_advanced_activation(inexpr, keras_layer, etab):
act_type = type(keras_layer).__name__

if act_type == 'Softmax':
return _op.nn.softmax(inexpr, axis=1)
axis = keras_layer.axis
dims = len(keras_layer.input_shape)

This comment has been minimized.

Copy link
@apivovarov

apivovarov Aug 28, 2019

Contributor

dims is needed in one particular case below. This line can be moved to the place where dims is used

wweic added a commit to wweic/tvm that referenced this pull request Sep 16, 2019
wweic added a commit to wweic/tvm that referenced this pull request Sep 16, 2019
wweic added a commit to neo-ai/tvm that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.