Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TFLite] Support depthwise convolution multiplier greater than 1 #3922

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@FrozenGene
Copy link
Contributor

commented Sep 9, 2019

Currently, TFLite FE only support depthwise convolution multiplier equals to 1. However, community users report we need this feature and Tensorflow FE has supported it too recently. This PR does support this.

Related links and discussions:

  1. https://discuss.tvm.ai/t/deployment-of-converted-pb-file-to-tflite-using-relay-frontend-from-tflite/3307/
  2. https://discuss.tvm.ai/t/tf-kernel-layout-hwio-vs-hwoi/3895

cc: @tmoreau89

@anijain2305
Copy link
Contributor

left a comment

Thanks a lot for the contribution :)

@FrozenGene FrozenGene force-pushed the FrozenGene:tflite_depthwise branch from 06d037d to 3a5d3e8 Sep 10, 2019

@FrozenGene

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@yzh119 @tqchen @kevinthesun @icemelon9 could someone help to manage it? Thanks.

@cchung100m
Copy link
Contributor

left a comment

Thanks and LGTM :)

@tmoreau89
Copy link
Contributor

left a comment

Thanks @FrozenGene for the changes and following up on our earlier conversation. The changes LGTM.

@tmoreau89 tmoreau89 merged commit 968ffef into dmlc:master Sep 11, 2019

5 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
windows_mac_build Build #20190910.8 succeeded
Details
windows_mac_build (MacOS_XCode9) MacOS_XCode9 succeeded
Details
windows_mac_build (Windows_VS2017_x64) Windows_VS2017_x64 succeeded
Details
windows_mac_build (Windows_VS2017_x86) Windows_VS2017_x86 succeeded
Details

@FrozenGene FrozenGene deleted the FrozenGene:tflite_depthwise branch Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.