Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use preprocessor to disable #define fopen64 std::fopen when built with mingw32-w64 #2958

Closed
KOLANICH opened this issue Dec 19, 2017 · 5 comments

Comments

@KOLANICH
Copy link
Contributor

KOLANICH commented Dec 19, 2017

In #1049 @yunzhou have found a solution to make it build using mingw32-w64 (the one which is sometimes used with anaconda). It was to comment out the line

#define fopen64 std::fopen

It's a shame that this have not beed implemented yet. It took me a lot of time to find this solution.

@KOLANICH KOLANICH changed the title Use preprocessor to disable #define fopen64 std::fopen Use preprocessor to disable #define fopen64 std::fopen when built with mingw32-w64 Dec 24, 2017
@tqchen tqchen closed this as completed Jul 4, 2018
@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jul 4, 2018

@tqchen, is this fix applied?

@hcho3
Copy link
Collaborator

hcho3 commented Jul 4, 2018

#2977 added installation instruction for MinGW.

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jul 4, 2018

This doesn't help, I still have to apply the patch mentioned in head post. I personally prefer it to be applied automatically with C++ preprocessor.

@hcho3
Copy link
Collaborator

hcho3 commented Jul 4, 2018

@KOLANICH Let me open a new issue for MinGW support then. Currently, CI tests for Windows target do build XGBoost with MinGW, so I thought the issue was solved.

@hcho3
Copy link
Collaborator

hcho3 commented Jul 4, 2018

@KOLANICH Can you post the exact version and variant of the compiler you are using in issue #3436?

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants