option to shuffle data in mknfolds #1459

Merged
merged 8 commits into from Dec 22, 2016

Projects

None yet

3 participants

@jokari69
Contributor

Add possibility to not shuffle the data when creating k folds.

@terrytangyuan
Member

Could you rebase? Also the additional argument shuffle might break some backward compatibility. Do you mind adding to one of the last arguments instead of the sixth argument?

Joris Van de... and others added some commits Aug 11, 2016
Joris Van der Mijnsbrugge option to shuffle data in mknfolds e7733e8
Joris Van der Mijnsbrugge removed possibility to run as stand alone test 9acd716
Joris Van der Mijnsbrugge split function def in 2 lines for lint
b9b059d
Joris Van der Mijnsbrugge merged
f9b1cc4
@codecov-io
codecov-io commented Dec 22, 2016 edited

Current coverage is 33.85% (diff: 100%)

Merging #1459 into master will decrease coverage by 0.01%

@@             master      #1459   diff @@
==========================================
  Files            68         68          
  Lines          5281       5281          
  Methods         827        827          
  Messages          0          0          
  Branches        526        526          
==========================================
- Hits           1789       1788     -1   
  Misses         3415       3415          
- Partials         77         78     +1   

Powered by Codecov. Last update b49b339...f9b1cc4

@jokari69
Contributor

Hey Terry, sorry for the late reply. I saw you added instance of folds to check as well, let me know if you have any more concerns.

Joris

@terrytangyuan terrytangyuan merged commit fb0fc0c into dmlc:master Dec 22, 2016

4 checks passed

codecov/patch Coverage not affected when comparing b49b339...f9b1cc4
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +66.12% compared to b49b339
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@terrytangyuan
Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment