Join GitHub today
[python-package] fix sklearn n_jobs/nthreads and seed/random_state bug #2378
this pull request
Jun 4, 2017
This looks great @wxchan! Thanks for getting on it so quickly. Could I request that we also fix the warnings in this PR? If we change the line:
warnings.filterwarnings('default', '.+nthread.+|.+seed.+', DeprecationWarning)
It will ensure that only those two warnings are raised. Currently, that line may inadvertently cause warnings in other packages to be raised.
@gaw89 I didn't find
@wxchan, sorry for being unclear. That is what I was meaning. Line 16. Perhaps this is bad practice to slip in a fix for multiple bugs under one PR, but it seemed like this might be a convenient place to fix it (rather than creating a whole PR for just one line). If it's a bad idea to make that fix here, I'm happy to submit it in a separate PR.
Thanks for the prompt attention!
I didn't include XGBoost in there, and you'll have to
Unfortunately, I tried checking out this commit and then rebuilding XGBoost, and it didn't seem to stop the error.
I found something interesting as well. I made a change to
I haven't tried building anything other than the master branch of xgb before, so i might have messed that part up, but hopefully this folder helps you reproduce the error!
sorry I am outside these days.
@ClimbsRocks I cannot reproduce error with your provided codes in aml_test.zip. seem already solved.
@gaw89 I suggest opening another pr, because I am not quite familiar with python warnings, afraid to get something wrong.
btw, who should I call for a review for this thread?