New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocking][jvm-packages] fix issue when spark job execution thread cannot return before we execute first() #3758

Merged
merged 11 commits into from Oct 6, 2018

Conversation

Projects
None yet
1 participant
@CodingCat
Member

CodingCat commented Oct 5, 2018

@chenqin please look at that thread join

@weitian it also contains some small fix for typos brought by ranking-related commits...

@CodingCat CodingCat changed the title from [jvm-packages] fix issue when spark job execution thread cannot return before we execute first() to [Blocking][jvm-packages] fix issue when spark job execution thread cannot return before we execute first() Oct 5, 2018

@hcho3 hcho3 referenced this pull request Oct 5, 2018

Closed

[ANNOUCEMENT] 0.81 release planned on November 1, 2018 #3744

12 of 12 tasks complete

@CodingCat CodingCat merged commit 785094d into dmlc:master Oct 6, 2018

5 checks passed

Jenkins: Build & Test Stage built successfully
Details
Jenkins: Get sources Stage built successfully
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@CodingCat CodingCat deleted the CodingCat:wait_for_thread branch Oct 6, 2018

CodingCat added a commit to CodingCat/xgboost that referenced this pull request Oct 25, 2018

[jvm-packages] fix issue when spark job execution thread cannot retur…
…n before we execute first() (dmlc#3758)

* add back train method but mark as deprecated

* add back train method but mark as deprecated

* add back train method but mark as deprecated

* add back train method but mark as deprecated

* fix scalastyle error

* fix scalastyle error

* fix scalastyle error

* fix scalastyle error

* sparjJobThread

* update

* fix issue when spark job execution thread cannot return before we execute first()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment