Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc about max_depth #4078

Merged
merged 2 commits into from Jan 30, 2019
Merged

fix doc about max_depth #4078

merged 2 commits into from Jan 30, 2019

Conversation

CodingCat
Copy link
Member

No description provided.

@CodingCat
Copy link
Member Author

@hcho3 , travis-ci is broken again?

@hcho3
Copy link
Collaborator

hcho3 commented Jan 29, 2019

@CodingCat This is rather frustrating. I might consider using other CI services for Mac testing, such as Circle CI.

Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a sentence to address @thvasilo 's comment.

@hcho3
Copy link
Collaborator

hcho3 commented Jan 29, 2019

@CodingCat Okay, I found a simple fix for the broken Mac build (see dmlc/treelite#69), no need to migrate the CI. I'll file a new PR soon.

doc/parameter.rst Outdated Show resolved Hide resolved
doc/parameter.rst Outdated Show resolved Hide resolved
Co-Authored-By: CodingCat <CodingCat@users.noreply.github.com>
@hcho3 hcho3 merged commit e0094d9 into dmlc:master Jan 30, 2019
@hcho3
Copy link
Collaborator

hcho3 commented Jan 30, 2019

Merged. Thanks!

@CodingCat CodingCat deleted the fix_doc branch January 30, 2019 20:57
@lock lock bot locked as resolved and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants