Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example pr for rabit cache #4636

Closed
wants to merge 46 commits into from

Conversation

Projects
None yet
3 participants
@chenqin
Copy link
Contributor

commented Jul 3, 2019

No description provided.

@chenqin chenqin force-pushed the chenqin:master branch from f20495d to 807ff49 Jul 4, 2019

@thvasilo

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Hey @chenqin, trying to check out this PR I get the following errors Server does not allow request for unadvertised object when checking out rabit:

git fetch origin pull/4636/head:chenqin
remote: Enumerating objects: 25, done.
remote: Counting objects: 100% (25/25), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 36 (delta 23), reused 24 (delta 23), pack-reused 11
Unpacking objects: 100% (36/36), done.
From https://github.com/dmlc/xgboost
 * [new ref]           refs/pull/4636/head -> chenqin
Fetching submodule dmlc-core
From https://github.com/dmlc/dmlc-core
   d06aceb..f1ff6cc  master     -> origin/master
Fetching submodule rabit
error: Server does not allow request for unadvertised object db343f9394470d63bc2c95551d3beb80f39086c3
error: Server does not allow request for unadvertised object ee234c4bb05422963491cae35f391d1e15d88f29
error: Server does not allow request for unadvertised object ef235c4308f64170d586743c6d0897239a7a55be
error: Server does not allow request for unadvertised object 7186da620fa4897545c34d8b7bb0a40cd8001e65
error: Server does not allow request for unadvertised object f32edca5812b1b5160c15ea2c40034048f5af843

@@ -223,6 +223,9 @@ void QuantileHistMaker::Builder::ExpandWithDepthWidth(
int sync_count = 0;
std::vector<ExpandEntry> temp_qexpand_depth;
BuildLocalHistograms(&starting_index, &sync_count, gmat, gmatb, p_tree, gpair_h);
//TODO (chen qin): remove me once root caused, force sync count in sync
rabit::Allreduce<rabit::op::Min>(&sync_count, sizeof(int));

This comment has been minimized.

Copy link
@CodingCat

CodingCat Jul 9, 2019

Member

obviously this is something should not be here

This comment has been minimized.

Copy link
@chenqin

chenqin Jul 13, 2019

Author Contributor

removed

This comment has been minimized.

Copy link
@CodingCat

CodingCat Jul 18, 2019

Member

it's still here?

@chenqin chenqin force-pushed the chenqin:master branch from e59bb6b to 5924cf7 Jul 9, 2019

chenqin added some commits Jul 11, 2019

apply multiple nodes die, combine approx/hist tests in one script
build against rabit/test branch with extensive logging in checkpoint consensus state
@chenqin

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2019

Hey @chenqin, trying to check out this PR I get the following errors Server does not allow request for unadvertised object when checking out rabit:

git fetch origin pull/4636/head:chenqin
remote: Enumerating objects: 25, done.
remote: Counting objects: 100% (25/25), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 36 (delta 23), reused 24 (delta 23), pack-reused 11
Unpacking objects: 100% (36/36), done.
From https://github.com/dmlc/xgboost
 * [new ref]           refs/pull/4636/head -> chenqin
Fetching submodule dmlc-core
From https://github.com/dmlc/dmlc-core
   d06aceb..f1ff6cc  master     -> origin/master
Fetching submodule rabit
error: Server does not allow request for unadvertised object db343f9394470d63bc2c95551d3beb80f39086c3
error: Server does not allow request for unadvertised object ee234c4bb05422963491cae35f391d1e15d88f29
error: Server does not allow request for unadvertised object ef235c4308f64170d586743c6d0897239a7a55be
error: Server does not allow request for unadvertised object 7186da620fa4897545c34d8b7bb0a40cd8001e65
error: Server does not allow request for unadvertised object f32edca5812b1b5160c15ea2c40034048f5af843

sorry about late reply can you give another try against? chenqin@7f5f278

@CodingCat

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

I just found this PR may also involve conflict with the issue at #4594 (where more rabit operations are to be added )

@chenqin

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

I just found this PR may also involve conflict with the issue at #4594 (where more rabit operations are to be added )

Let's review design document first once it's out.

@chenqin chenqin closed this Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.