Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[jvm-packages] update local dev build process #4640
@CodingCat are you referring to the MVN download, or the building/tagging of the Dockerfile?
I am talking about yum install part
@CodingCat with this PR, if you run
However, I agree that we should stop MVN trying to download the jars every time. (I will look into mounting the users home folder)
@CodingCat I have made some changes:
Jul 8, 2019
@CodingCat I have attempted to make a
Should we COPY the
I tried 7cf9f94 in my locally checked out xgboost folder and build-linux.sh failed with
I think it is because I have already build it locally
I'll retry it on the clean clone
is it really necessary? I personally think it will make the process error-prone. Clean everything after building for another arch is not something "too strict"....
Though I didn't verify, if we have different output folder, are we even able to run linux & mac build in parallel? and if that's the case, are we messing up the object files? even not, I would choose to keep the build step as strict as possible to avoid any unexpected behavior
Jul 16, 2019
9 of 10 checks passed
Sorry for polluting this closed pull request.
I rerun jvm dev scripts on my linux dev machine again and I realised what kind of problem did I have.
So if I have a folder which I develop & build locally then I use this scripts to build a jar then I cannot go back to developing locally without manually cleaning all artifacts cause they are all owned by root
As far as I understand you should not have this problem on OS X or Windows
Why do I want to use these scripts if I already have a linux machine? The reason is I need to build a native shared library inside CentOS 6 docker otherwise I won't be able to use xgboost-spark on my cluster cause this cluster has an old OS with an old libc
That being said there are some work around (mainly this one https://www.jujens.eu/posts/en/2017/Jul/02/docker-userns-remap/) but I think after applying it I won't be able to use ci_build scripts
What do you think if I would modify the Docker container and the scripts to use entrypoint.sh like all other CI build scripts do?