Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public group getter for java and scala #4838

Merged
merged 8 commits into from Sep 9, 2019

Conversation

@stpyang
Copy link
Contributor

commented Sep 6, 2019

No description provided.

@stpyang stpyang force-pushed the stpyang:add_groupgetter branch 7 times, most recently from 09339e3 to 8c1327a Sep 6, 2019

@hcho3

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

@stpyang Thanks for your contribution. Take a look at our contribution guideline: https://xgboost.readthedocs.io/en/latest/contrib/index.html.

@stpyang stpyang force-pushed the stpyang:add_groupgetter branch from 8c1327a to e8d733e Sep 6, 2019

@hcho3

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

@stpyang I see that you've force-pushed the pull request 4 times in a row without any change. Is there something you're trying to accomplish? Note that force-pushing will not make tests run faster

@stpyang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

No, sorry, I was just catching typos that i wanted to fix.

Stephanie Yang added 3 commits Sep 6, 2019
Stephanie Yang
Stephanie Yang
@hcho3

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

@stpyang Is this ready now?

@stpyang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

Yes

@hcho3

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

@stpyang How did you test your proposed changes?

@stpyang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

This is a subset of some forked code that we use in production at my company.

Stephanie Yang

@stpyang stpyang force-pushed the stpyang:add_groupgetter branch from ab0dfcb to 4874966 Sep 6, 2019

Stephanie Yang and others added 3 commits Sep 6, 2019
Stephanie Yang
Stephanie Yang
@codecov-io

This comment has been minimized.

Copy link

commented Sep 7, 2019

Codecov Report

Merging #4838 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4838   +/-   ##
=======================================
  Coverage   77.51%   77.51%           
=======================================
  Files          11       11           
  Lines        2055     2055           
=======================================
  Hits         1593     1593           
  Misses        462      462

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f90e7f9...836520e. Read the comment docs.

@hcho3
hcho3 approved these changes Sep 7, 2019

@stpyang stpyang changed the title Add public group getter for java Add public group getter for java and scala Sep 7, 2019

@stpyang stpyang referenced this pull request Sep 7, 2019
2 of 4 tasks complete
@stpyang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2019

I altered the name of this commit from Add public group getter for java to Add public group getter for java and scala

@hcho3 hcho3 requested a review from CodingCat Sep 8, 2019

@hcho3 hcho3 merged commit 0fc7dcf into dmlc:master Sep 9, 2019

12 checks passed

Jenkins Linux: Build Stage built successfully
Details
Jenkins Linux: Formatting Check Stage built successfully
Details
Jenkins Linux: Get sources Stage built successfully
Details
Jenkins Linux: Test Stage built successfully
Details
Jenkins Win64: Build Stage built successfully
Details
Jenkins Win64: Get sources Stage built successfully
Details
Jenkins Win64: Test Stage built successfully
Details
codecov/patch Coverage not affected when comparing f90e7f9...836520e
Details
codecov/project 77.51% remains the same compared to f90e7f9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hcho3

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

@stpyang We're merging this now. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.