From d75742c32981c667001931ee35df4370861d2de9 Mon Sep 17 00:00:00 2001 From: Hyunsu Cho Date: Fri, 20 Mar 2020 03:45:36 -0700 Subject: [PATCH] Define _CRT_SECURE_NO_WARNINGS to remove unneeded warnings in MSVC --- CMakeLists.txt | 16 ++++++++++++++++ src/CMakeLists.txt | 2 ++ tests/cpp/CMakeLists.txt | 2 ++ 3 files changed, 20 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 30ee45d0aed9..5bf86f637dfe 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -111,6 +111,14 @@ set_target_properties(dmlc PROPERTIES CXX_STANDARD_REQUIRED ON POSITION_INDEPENDENT_CODE ON) list(APPEND LINKED_LIBRARIES_PRIVATE dmlc) +if (MSVC) + target_compile_options(dmlc PRIVATE + -D_CRT_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE) + if (TARGET dmlc_unit_tests) + target_compile_options(dmlc_unit_tests PRIVATE + -D_CRT_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE) + endif (TARGET dmlc_unit_tests) +endif (MSVC) # rabit set(RABIT_BUILD_DMLC OFF) @@ -120,8 +128,16 @@ add_subdirectory(rabit) if (RABIT_MOCK) list(APPEND LINKED_LIBRARIES_PRIVATE rabit_mock_static) + if (MSVC) + target_compile_options(rabit_mock_static PRIVATE + -D_CRT_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE) + endif (MSVC) else() list(APPEND LINKED_LIBRARIES_PRIVATE rabit) + if (MSVC) + target_compile_options(rabit PRIVATE + -D_CRT_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE) + endif (MSVC) endif(RABIT_MOCK) # Exports some R specific definitions and objects diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 88b62088d9c9..3c1fa8a87a94 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -61,6 +61,8 @@ endif (WIN32 AND MINGW) if (MSVC) target_compile_options(objxgboost PRIVATE $<$>:/utf-8> + -D_CRT_SECURE_NO_WARNINGS + -D_CRT_SECURE_NO_DEPRECATE ) endif (MSVC) diff --git a/tests/cpp/CMakeLists.txt b/tests/cpp/CMakeLists.txt index f773aadc0109..740f57c81fb4 100644 --- a/tests/cpp/CMakeLists.txt +++ b/tests/cpp/CMakeLists.txt @@ -53,6 +53,8 @@ endif (USE_CUDA) if (MSVC) target_compile_options(testxgboost PRIVATE $<$>:/utf-8> + -D_CRT_SECURE_NO_WARNINGS + -D_CRT_SECURE_NO_DEPRECATE ) endif (MSVC)