-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pyspark] Implement SparkXGBRanker estimator #8172
Conversation
CC @trivialfis @wbo4958 Thank you ! |
Apologies for the delay, will take a deeper look tomorrow. |
CC @trivialfis @wbo4958 Thanks! |
|
||
class SparkXGBRanker(_SparkXGBEstimator): | ||
"""SparkXGBRanker is a PySpark ML estimator. It implements the XGBoost | ||
classification algorithm based on XGBoost python library, and it can be used in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be It implements the XGBoost **ranking** algorithm based on XGBoost python library
instead of classification algorithm? I noticed that there are quite a few references to classification left behind in this block comment... should they and the example provided below be updated to ranking so the documentation comes out right?
Just to avoid confusion for new users like me trying to use this new estimator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WeichenXu123 Would you like to open a fix?
Closes #8110
Implement SparkXGBRanker estimator.