Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pyspark] Implement SparkXGBRanker estimator #8172

Merged
merged 18 commits into from
Aug 22, 2022

Conversation

WeichenXu123
Copy link
Contributor

Closes #8110

Implement SparkXGBRanker estimator.

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@WeichenXu123
Copy link
Contributor Author

CC @trivialfis @wbo4958 Thank you !

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@trivialfis
Copy link
Member

Apologies for the delay, will take a deeper look tomorrow.

@WeichenXu123
Copy link
Contributor Author

CC @trivialfis @wbo4958 Thanks!

@trivialfis trivialfis merged commit f4628c2 into dmlc:master Aug 22, 2022

class SparkXGBRanker(_SparkXGBEstimator):
"""SparkXGBRanker is a PySpark ML estimator. It implements the XGBoost
classification algorithm based on XGBoost python library, and it can be used in
Copy link

@deep-kotadia2-zocdoc deep-kotadia2-zocdoc Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be It implements the XGBoost **ranking** algorithm based on XGBoost python library instead of classification algorithm? I noticed that there are quite a few references to classification left behind in this block comment... should they and the example provided below be updated to ranking so the documentation comes out right?

Just to avoid confusion for new users like me trying to use this new estimator.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WeichenXu123 Would you like to open a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xgboost spark: Support XGBRanker
3 participants