Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy data from Ellpack to GHist. #8215

Merged
merged 16 commits into from
Sep 6, 2022
Merged

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Sep 1, 2022

This enables XGBoost to train with hist tree method on CPU with GPU-initialized QuantileDMatrix.

Related: #7890 .

@trivialfis trivialfis mentioned this pull request Sep 1, 2022
4 tasks
Copy link
Member

@RAMitchell RAMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, awesome to have interoperability here.

Xy = xgb.QuantileDMatrix(X[0], y[0], weight=w[0])
booster_0 = xgb.train({"tree_method": "gpu_hist"}, Xy, num_boost_round=4)
# from CPU
Xy = xgb.QuantileDMatrix(X[0], y[0], weight=w[0], max_bin=max_bin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice. The interface just works and there is no confusion for users.

@trivialfis trivialfis merged commit 441ffc0 into dmlc:master Sep 6, 2022
@trivialfis trivialfis deleted the ellpack-hist branch September 6, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants