Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO_DOMAIN do not support on AIX, using getsockname instead #8437

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

zheddie
Copy link
Contributor

@zheddie zheddie commented Nov 8, 2022

getsockopt do not support SO_DOMAIN on AIX/IBM i . Using the getsockname() instead to get the domain info. thanks.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, does it work if the socket is not yet binded?

@trivialfis
Copy link
Member

You can check the result based on cpp unittest testxgboost --gtest_filter=Socket.Basic.

@zheddie
Copy link
Contributor Author

zheddie commented Nov 9, 2022

@trivialfis thanks. Can you help me how to build out the testxgboost utility?

@zheddie
Copy link
Contributor Author

zheddie commented Nov 9, 2022

Thank you for the fix, does it work if the socket is not yet binded?

Yes. the domain could be retrieved just after the socket been created by socket() routine.

@trivialfis
Copy link
Member

XGBoost requires googletest to build its c++ tests.

cmake path/to/xgboost -DGOOGLE_TEST=ON
make
./testxgboost

@zheddie
Copy link
Contributor Author

zheddie commented Nov 10, 2022

Not sure whether this is a MUST for the PR , as we do not have googletest available on our OS yet :-(.
This PR, as covered by the __PASE__ macro , would only affected our system.

@trivialfis trivialfis merged commit 0c6266b into dmlc:master Nov 10, 2022
@zheddie
Copy link
Contributor Author

zheddie commented Nov 25, 2022

BTW, how can we make sure this fix tobe integrated in next release/fixpack ? @trivialfis thanks.

@trivialfis
Copy link
Member

@zheddie We will.

@trivialfis trivialfis mentioned this pull request Nov 29, 2022
9 tasks
hcho3 pushed a commit to hcho3/xgboost that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants