-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SO_DOMAIN do not support on AIX, using getsockname instead #8437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix, does it work if the socket is not yet binded?
You can check the result based on cpp unittest |
@trivialfis thanks. Can you help me how to build out the testxgboost utility? |
Yes. the domain could be retrieved just after the socket been created by socket() routine. |
XGBoost requires googletest to build its c++ tests.
|
Not sure whether this is a MUST for the PR , as we do not have googletest available on our OS yet :-(. |
BTW, how can we make sure this fix tobe integrated in next release/fixpack ? @trivialfis thanks. |
@zheddie We will. |
Co-authored-by: GavinZhang <zhanggan@cn.ibm.com>
getsockopt do not support SO_DOMAIN on AIX/IBM i . Using the getsockname() instead to get the domain info. thanks.