Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] Support different types of filesystems #965

Merged
merged 1 commit into from Mar 11, 2016
Merged

Conversation

@shaform
Copy link
Contributor

@shaform shaform commented Mar 11, 2016

As noted here: http://stackoverflow.com/a/16278054/3455159, we need to change the code a little bit to support different filesystems such as S3FileSystem.

@CodingCat
Copy link
Member

@CodingCat CodingCat commented Mar 11, 2016

@shaform thanks for the PR, have you meet the problem when working with S3 ?

I think in sparkContext.hadoopConfiguration, it shall return the S3FileSystem correctly?

@shaform
Copy link
Contributor Author

@shaform shaform commented Mar 11, 2016

I tried saving the model to S3 and failed. Since the FileSystem actually depends on the path (one might mix S3 and other paths), sparkContext.hadoopConfiguration is not enough.
Another way is to use FileSystem.get(uri, context.getConfiguration()) as noted in the same stackoverflow.

@CodingCat
Copy link
Member

@CodingCat CodingCat commented Mar 11, 2016

OK, so your source/destination are just two different file systems?

BTW, would you please update the branch, once the travis says OK, I will merge it

@shaform shaform force-pushed the shaform:fs branch from 26ed1ce to 6558ef3 Mar 11, 2016
CodingCat added a commit that referenced this pull request Mar 11, 2016
Support the cases when user load dataset and save model to two different file systems
@CodingCat CodingCat merged commit 8e3ce90 into dmlc:master Mar 11, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@CodingCat
Copy link
Member

@CodingCat CodingCat commented Mar 11, 2016

Thanks, @shaform , merged in

@CodingCat CodingCat changed the title Support different types of filesystems [jvm-packages] Support different types of filesystems Mar 11, 2016
@shaform
Copy link
Contributor Author

@shaform shaform commented Mar 11, 2016

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.