Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day Time Duration division #6

Closed
opatrascoiu opened this issue Jun 30, 2017 · 4 comments
Closed

Day Time Duration division #6

opatrascoiu opened this issue Jun 30, 2017 · 4 comments

Comments

@opatrascoiu
Copy link
Contributor

opatrascoiu commented Jun 30, 2017

0007-date-time.dmn contains a literal expression

                 <literalExpression>
			<text>dtDuration2 / oneHour</text>
		</literalExpression>

where both operands are typeRef="feel:dayTimeDuration"

I believe this is not supported in DMN 1.1. (see Table 47: Specific semantics of multiplication and division )

I think we should replace the literal expression with

                 <literalExpression>
			<text>dtDuration2.hours</text>
		</literalExpression>

and test the "hours" member.

@opatrascoiu opatrascoiu changed the title Duration division Day Time Duration division Jun 30, 2017
@brsilver
Copy link
Contributor

I agree dividing a duration by a duration is omitted from the spec, but I think inadvertent admission. Proposed solution of using hours property is incorrect; it just extracts the hours component, an integer. We should move this test to the "non-compliant tests" section of test cases.

@brsilver
Copy link
Contributor

We will propose fix to the omission in RTF.

@etirelli
Copy link
Contributor

Submitted PR #20

agilepro pushed a commit that referenced this issue Aug 1, 2017
@etirelli
Copy link
Contributor

etirelli commented Aug 1, 2017

Fixed.

@etirelli etirelli closed this as completed Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants