Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Build failures on main from references to yarn #85

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 20, 2023 · 1 comment · Fixed by #86
Closed
3 tasks done

🛠 Tooling: Build failures on main from references to yarn #85

JoshuaKGoldberg opened this issue Dec 20, 2023 · 1 comment · Fixed by #86
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Collaborator

JoshuaKGoldberg commented Dec 20, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

From https://github.com/dmnd/dedent/actions/runs/7278084706/job/19831511946?pr=84:

Run pnpm build

> dedent@1.5.1 build /home/runner/work/dedent/dedent
> yarn build:legacy && yarn build:modern && yarn build:types

error This project's package.json defines "packageManager": "yarn@pnpm@8.[7](https://github.com/dmnd/dedent/actions/runs/7278084706/job/19831511946?pr=84#step:4:8).0". However the current global version of Yarn is 1.22.21.

Looks like I missed some references to yarn.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! area: tooling Managing the repository's maintenance labels Dec 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 20, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 20, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 20, 2023
@JoshuaKGoldberg
chore: replace last yarn references with pnpm (#86)
a4f30bf 
## PR Checklist

- [x] Addresses an existing open issue: fixes #85
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/dmnd/dedent/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/dmnd/dedent/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Fixes the last few `yarn` references in `package.json` scripts to
instead say `pnpm`.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.5.2 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace last yarn references with pnpm dmnd/dedent
1 participant
@JoshuaKGoldberg